Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pydantic v2 #679

Closed
DominicOram opened this issue Jul 16, 2024 · 7 comments · Fixed by #764
Closed

Move to pydantic v2 #679

DominicOram opened this issue Jul 16, 2024 · 7 comments · Fixed by #764
Assignees

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Jul 16, 2024

We should make sure that all our dependencies etc. work on pydantic v2

Acceptance Criteria

  • We pin pydantic>2
  • Unpin zocalo < 1.0.0
  • We remove all the ignores around pydantic in filterwarnings
  • Dependencies are happy to install on pip install
  • Unit tests work
@DominicOram
Copy link
Contributor Author

@dperl-dls
Copy link
Collaborator

Once we can, we should then update some of the way we use pydantic features, e.g.:

) # should be replaced with model_validator once move to pydantic 2 is complete

@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Aug 12, 2024
@dperl-dls
Copy link
Collaborator

dperl-dls commented Aug 13, 2024

We are now blocked by scanspec requiring numpy>=2.0 and p4p requiring numpy<2.0

blueapi and nexgen also still pinned to pydantic<2 (so we can't pin to >2 and have a working environment)

additionally some changes are needed to get dodal in sync with ophyd_async 0.5+

@DominicOram DominicOram moved this from Candidates for Next Sprint to Blocked in Hyperion Aug 19, 2024
@DominicOram
Copy link
Contributor Author

Waiting for another release of p4p

@DiamondJoseph DiamondJoseph self-assigned this Aug 29, 2024
@DiamondJoseph
Copy link
Contributor

I believe we're currently not blocked by p4p- only Numpy 2 support is. I'm going to make the required changes and check

@dperl-dls
Copy link
Collaborator

@DiamondJoseph yes, but unfortunately the version of scanspec which supports pydantic 2 also requires numpy 2, so we are indirectly still blocked by that

@DiamondJoseph
Copy link
Contributor

Not since ScanSpec 0.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants