Minimal configuration for inserting documents into Tiled #755
Conversation
DiamondJoseph
force-pushed
the
tiled-insertion
branch
from
324c226 to
f3767e1
Compare
| @@ -95,7 +99,8 @@ addopts = """ | |||
| --ignore=src/blueapi/startup | |||
| """ | |||
| # https://iscinumpy.gitlab.io/post/bound-version-constraints/#watch-for-warnings | |||
| filterwarnings = ["error", "ignore::DeprecationWarning"] | |||
| # Unignore UserWarning after Pydantic warning removed from bluesky/bluesky and release | |||
There was a problem hiding this comment.
- a release of bluesky
There was a problem hiding this comment.
Should: Include issue link in a comment in the file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 93.32% 92.99% -0.34%
==========================================
Files 38 38
Lines 2083 2099 +16
==========================================
+ Hits 1944 1952 +8
- Misses 139 147 +8 ☔ View full report in Codecov by Sentry. |
src/blueapi/config.py
Outdated
| Config for connecting to a tiled instance | ||
| """ | ||
|
|
||
| uri: str |
There was a problem hiding this comment.
Could: Can we use separate host and port fields to be consistent with the other config models?
| @@ -95,7 +99,8 @@ addopts = """ | |||
| --ignore=src/blueapi/startup | |||
| """ | |||
| # https://iscinumpy.gitlab.io/post/bound-version-constraints/#watch-for-warnings | |||
| filterwarnings = ["error", "ignore::DeprecationWarning"] | |||
| # Unignore UserWarning after Pydantic warning removed from bluesky/bluesky and release | |||
| filterwarnings = ["error", "ignore::DeprecationWarning", "ignore::UserWarning"] | |||
There was a problem hiding this comment.
Is there any way to only ignore warnings from the tests in question? Otherwise we may end up removing this in a few months time only to find the tests blowing up in a bunch of other places?
src/blueapi/service/interface.py
Outdated
| @@ -48,6 +50,19 @@ def worker() -> TaskWorker: | |||
| return worker | |||
|
|
|||
|
|
|||
| @cache | |||
| def tiled_inserter(): | |||
There was a problem hiding this comment.
Should:
| def tiled_inserter(): | |
| def tiled_inserter() -> TiledClient: |
...or whatever it's called
| @@ -95,7 +99,8 @@ addopts = """ | |||
| --ignore=src/blueapi/startup | |||
| """ | |||
| # https://iscinumpy.gitlab.io/post/bound-version-constraints/#watch-for-warnings | |||
| filterwarnings = ["error", "ignore::DeprecationWarning"] | |||
| # Unignore UserWarning after Pydantic warning removed from bluesky/bluesky and release | |||
There was a problem hiding this comment.
Should: Include issue link in a comment in the file
No description provided.