Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

562 investigate splitting into entrypoints with a shared dockerfile base #563

Conversation

stan-dot
Copy link
Contributor

refactor around the worker and protobuf. not complete yet.

based on todo.md

  • can deploy one package just with different entrypoints, even the same dockerfile, just different entrypoints
  • move the blueapi initalization logic away from CLI - ApplicationConifg is too self-indulgent
  • all handler references should be replaced by the grpc client OR just the refernce to the context
  • move the blueworker config types to proto
  • no refernce to pydantic inside the worker

Keeping most of the context inside the worker (such as devices and plans) as the blueapi only needs parts of the plan. we can generate the json schema needed for autogeneration inside the worker and serialize it there. That way we contain the chaos of uploading arbitrary code to the worker only.

We'd represent the props to run a plan in a
message Plan{ string name = 1; google.protobuf.Struct props = 2; }

@stan-dot stan-dot added enhancement New feature or request dependencies Pull requests that update a dependency file python Pull requests that update Python code rest api Potential REST API changes client Relates to client code cli Relates to CLI code worker Relates to worker code labels Jul 18, 2024
@stan-dot stan-dot requested a review from callumforrester July 18, 2024 16:42
@stan-dot stan-dot self-assigned this Jul 18, 2024
@stan-dot stan-dot linked an issue Jul 18, 2024 that may be closed by this pull request
@stan-dot stan-dot changed the title 562 investigate splitting into many packages with a shared dockerfile base 562 investigate splitting into entrypoints with a shared dockerfile base Jul 18, 2024
@stan-dot
Copy link
Contributor Author

stan-dot commented Aug 1, 2024

this is not useful and not easily mergeable in the current state, a fresh approach on another day would be better

@stan-dot stan-dot closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Relates to CLI code client Relates to client code dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code rest api Potential REST API changes worker Relates to worker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate splitting into many packages with a shared Dockerfile-base
1 participant