-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lazy devices #515
Support lazy devices #515
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 91.10% 91.06% -0.05%
==========================================
Files 40 40
Lines 1787 1779 -8
==========================================
- Hits 1628 1620 -8
Misses 159 159 ☔ View full report in Codecov by Sentry. |
PR title |
83208ca
to
6ca50dd
Compare
Todo: just fix tests, then push and mark PR as ready |
I commented in the ophyd-async repo towards the resolution of the test errors here |
The relevant ophyd-async ticket is bluesky/ophyd-async#387, not bluesky/ophyd-async#413. The short term fix is to cap |
c6e9ace
to
ce7ec31
Compare
@callumforrester so we need to support both ophydv1 and ophyd-async devices? |
|
420f27f
to
8ed8301
Compare
I just realized that there is no clear way to see if a device is lazy or not. this might need to wait until DiamondLightSource/dodal#483 is done |
@stan-dot yes both should be supported for now, dodal is going to fully move off ophys v1 eventually, but probably not soon |
3a93600
to
c72b6da
Compare
c72b6da
to
638df00
Compare
closing as out of date - the change of blueapi plan to register_plan is unrelated. furthermore no PR is meaningful here until the dodal issue is done |
Outlined the places where the code needs to be modify to support the requested features.
Some alignment must happen on what is the best format to store the devices that are lazy.
I'd rather do it in the start of the PR.
#363 and #504 would change how this works however I think that this PR is mergeable much earlier than that.
Then, on my end I think the lazy devices would be best presented as:
properties on the Context object.