Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more comprehensive docstrings to values, using helm-docs tool #346

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rosesyrett
Copy link
Contributor

Added extra descriptions in the helm documentation for the values.yaml file. Auto generated a README in the helm repository containing this information in a table.

Perhaps we should setup a CI job to do this, as part of this PR? I think this should also be done for the nexus-filewriting-service.

@rosesyrett
Copy link
Contributor Author

Note: on github currently the README looks a little squished and I'm not sure the best way of fixing this... https://github.com/DiamondLightSource/blueapi/tree/helm-docs/helm/blueapi

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (d1b283b) to head (cff51a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files          35       35           
  Lines        1800     1800           
=======================================
  Hits         1662     1662           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot
Copy link
Contributor

re: inclusion in the CI - this is important for Developer Experience

there is a list of possible actions for running helm-docs, though all seem not maintained as much:

@stan-dot stan-dot added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers github_actions Pull requests that update GitHub Actions code labels Nov 14, 2024
@callumforrester
Copy link
Contributor

Fixes #660

@stan-dot feel free to experiment

@DiamondJoseph
Copy link
Contributor

For a lot of these, it may be worth re-running helm create and seeing what comments are present, stick with what is readily available if sufficient and not roll our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants