-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more comprehensive docstrings to values, using helm-docs tool #346
base: main
Are you sure you want to change the base?
Conversation
…sing helm-docs tool
Note: on github currently the README looks a little squished and I'm not sure the best way of fixing this... https://github.com/DiamondLightSource/blueapi/tree/helm-docs/helm/blueapi |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 35 35
Lines 1800 1800
=======================================
Hits 1662 1662
Misses 138 138 ☔ View full report in Codecov by Sentry. |
re: inclusion in the CI - this is important for Developer Experience there is a list of possible actions for running helm-docs, though all seem not maintained as much: |
For a lot of these, it may be worth re-running helm create and seeing what comments are present, stick with what is readily available if sufficient and not roll our own. |
Added extra descriptions in the helm documentation for the values.yaml file. Auto generated a README in the helm repository containing this information in a table.
Perhaps we should setup a CI job to do this, as part of this PR? I think this should also be done for the nexus-filewriting-service.