Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1064: Display dropdown or span depending on number of schema options #870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Dec 2, 2024

JIRA ticket: LIMS-1064

Summary:

In #621 we hard-coded the UI to say only CHIMP auto-scores were available. There are 275 plates in the database with MARCO scores, and of course other schemas may be used in future, So we should show a dropdown if mulitple schema results return, but just a span if only one schema results return.

Changes:

  • Re-enable the schema dropdown, as well as an empty span
  • Show or hide them according to the number of schemas returned

To test:

  • Go to a container inspection with both MARCO and CHIMP scores, eg /containers/cid/177952, inspection on 9th Dec 2020, check a dropdown appears to choose between MARCO and CHIMP scores
  • Switch to an older inspection (eg 21st July 2020) which just has MARCO scores, check the dropdown disappears and it just says "MARCO Auto Scores"
  • Go to a newer plate (eg /containers/cid/317254) with just CHIMP scores, check it says "CHIMP Auto Scores"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants