Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-103: Fix various bugs in Screens UI #863

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-103

Summary:

Fix various minor bugs in the adding and editing of Screens.

Changes:

  • Clicking "Add Screen" now adds a new screen to the current page rather than the next page
  • The Global attribute is now set on creation
  • If you are on the proposal that 'owns' a screen, you can now edit the container type (and therefore the capacity), or set it to null (default capacity of 96)
  • Cell A1 is now selected for you when you first go to a screen
  • Fix mis-spellings of "Crystallisation"

To test:

  • Go to proposal mx17352, then click "Imaging" in the top right, then click "Crystallisation Screens" (under "Imaging Dashboard")
  • Click "Add Screen", check an empty row appears on the page you are on
  • Name the screen and set global to "Yes", click the tick, then click on the screen, check the Global has been set to Yes.
  • Edit the container type and check the capacity updates. Check it perseveres after a page refresh. Set it back to null and check the capacity returns to 96, even after a page refresh.
  • Go back to the Screens list, click on Ax-CP-CUSTOM-101. Check position A1 is highlighted and the components are shown.
  • Go back to the Screens list, click on Test Screen 1a (on the last page). This is owned by a different proposal, check the container type is not displayed and the capacity is not editable.

@gfrn gfrn self-requested a review November 27, 2024 11:26
api/src/Page/Shipment.php Outdated Show resolved Hide resolved
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants