LIMS-753: Allow LN2 topups as part of dewar history #856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-753
Summary:
We record every time a dewar is topped up with LN2, but in the
Dewar.comments
field. In order to let the users know what has happened to their dewar, we should record it in theDewarTransportHistory
table.Once this code is live, I can edit the Dewar Logistics code to use this endpoint instead.
Changes:
shipments/dewars/history
endpoint with aSTATUS
instead of aLOCATION
.DewarTransportHistory
(and notDewar
) if onlySTATUS
givenTo test:
$bcr
variable in config.php to include the IP of a machine you can ping your server fromIf you get a 401 response, double check the $bcr variable. If you get a 200, go the dewar page on your Synchweb instance and check if the status has been added to the history. If no history shows, you might need to remove your IP from $bcr, it can get in the way. It should look like this:
LOCATION
sent in instead ofSTATUS
. Check the dewar location has changed in both theDewar
andDewarTransportHistory
tables.