Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1514: Allow sorting of visit list #854

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Nov 1, 2024

JIRA ticket: LIMS-1514

Summary:

The list of visits for a proposal is not sortable.

Changes:

  • Combine the data collection count into the main db query so that it can be sorted on
  • Remove the need for an enter press on searching for a visit number, but add a debounce
  • Make column headers actually be buttons so that the cursor becomes a pointer
  • Re-fetch the data with a sort parameter if a header is clicked (apart from "Dewars")
  • Re-fetch the data in the opposite direction if the same header is clicked again
  • Don't add a search parameter if the search box is empty
  • Allow searching by beamline name

To test:

  • Open a proposal with a bunch of visits eg mx34263, and go to the /visits page
  • Check you can sort by each header, in both directions, apart from "Dewars"
  • Check the number of Data Collections is the same as on prod
  • Search for a visit number, check only that visit number is displayed, check the debounce is working by looking at the requests sent
  • Search for a beamline (eg i03), check only visits for that beamline are displayed

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.3 December 3, 2024 09:23
@ndg63276 ndg63276 merged commit 443a354 into pre-release/2024-R5.3 Dec 3, 2024
2 checks passed
ndg63276 added a commit that referenced this pull request Dec 3, 2024
ndg63276 added a commit that referenced this pull request Dec 3, 2024
@ndg63276
Copy link
Collaborator Author

ndg63276 commented Dec 3, 2024

This change was reverted, and this PR is replaced by #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants