Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework orchestration service #13

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Conversation

TomDijkema
Copy link
Contributor

PR start the rework of the Orchestration front-end.

This part rebuilds the form for adding Source Systems and Mappings to a wizard type which is far more overseeable.
It also adds detail pages for Source Systems and Mappings.

The same will be done for MAS in a later PR.
This PR contains a bunch of loose ends which will also be picked up in the next PR, to reduce the amount of lines of code that are being published in this PR.

Move types definition file to /app directory, remove global directory
Commit to save progress
Commit made to back-up code because of shift in OS version
This commit adds a new form wizard to the orchestration front-end which is way more overseeable when adding or editing a source system or mapping, support for MAS will come later. Detail pages for Source System and Mapping have also been added.

There are still a bunch of loose ends with this code, which will be extended upon in a new PR to reduce the amount of lines of code pushed.
@TomDijkema TomDijkema self-assigned this Feb 15, 2024
Commit for resolving Sonar Cloud issues
Second commit for resolving Sonar Cloud issues
Copy link
Collaborator

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top! Paar kleine opmerkingen.
Daarnaast heb ik op de backend nog wat aanpassingen gemaakt die ik met je moet doorspreken. Dat zit nu in PR en vraagt ook een paar FE wijzigingen.

src/app/Utilities.ts Outdated Show resolved Hide resolved
src/app/Utilities.ts Show resolved Hide resolved
src/app/Utilities/FormBuilderUtilities.ts Show resolved Hide resolved
src/app/Utilities/FormBuilderUtilities.ts Outdated Show resolved Hide resolved
src/components/formBuilder/FormBuilder.tsx Outdated Show resolved Hide resolved
src/components/mapping/Mapping.tsx Outdated Show resolved Hide resolved
src/components/mapping/components/MappingMetaForm.tsx Outdated Show resolved Hide resolved
Commit addressing Review comments
Second commit to address Review comments
Copy link

sonarcloud bot commented Mar 4, 2024

@samleeflang samleeflang self-requested a review March 4, 2024 13:13
Copy link
Collaborator

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐢

@TomDijkema TomDijkema merged commit 052329a into main Mar 4, 2024
2 checks passed
@TomDijkema TomDijkema deleted the ReworkOrchestrationService branch March 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants