Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julias zi/adapt_hd_dio_calib #726

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

jul-sm
Copy link
Contributor

@jul-sm jul-sm commented Aug 10, 2023

Changes proposed in this pull request:

  • adapt DIO calibration of the HDAWG
  • replace qcodes with qcodes_loop in library imports

@MiniSean @wvlothuizen

In order for the pull request to be merged, the following conditions must be met:

  • test suite (Github actions) passes
  • all reasonable issues raised by codacy must be resolved
  • a positive review is required

Whenever possible the pull request should

  • follow the PEP8 style guide
  • have tests for the code
  • be well documented and contain comments

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

@jul-sm jul-sm requested review from MiniSean and wvlothuizen August 10, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants