Bugfix Release 0.8.3
Summary
This release of ripple1d
fixes several bugs that were identified in a large production run. Those bugs were detailed and summarized in #268.
Bug Fixes
- When a new terrain is downloaded but contains only nodata values,
NullTerrainError
is raised, and the endpoint process will fail. - When a new terrain is downloaded but the HEC-RAS CreateTerrain subprocess fails silently, the output is checked, and a
RasTerrainFailure
error is raised. Additionally, bad_projection_test.py has been added to test that the error will raise. - When a source model is conflated such that the most downstream XS for a NWM reach a has higher river station than the most upstream reach, a
BadConflation
error is raised. - When sub model extraction is attempted on a reach that would have one or zero cross-sections but is not tagged as eclipsed, a
SingleXSModel
error is raised. The endpoint response was also cleaned up such that eclipsed reaches no longer return a path to a nonexistent 123.ripple1d.json. Logging has been improved for all these cases. - flow indexing in the create_flow_depth_combinations function has been improved to avoid rounding values. A test has been added for one of the models that was causing problems.
- Handling of interpolated cross-sections has been improved such that they may have sub models created, may be run, and may be used in the create FIM lib steps. A new test model -- winooski -- has been added with interpolated cross-sections.
- Null (blank) downstream reach values are now loaded as 0. This is consistent with how HEC-RAS handles them. The new winooski model contains null downstream reach length at the most downstream cross-section.
Closes #281
Closes #282
Closes #291
Closes #292
Closes #295
Closes #298