video: adjust device_limits/features to the updated profiles #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Cheraghi <[email protected]>
Signed-off-by: Ali Cheraghi <[email protected]>
Signed-off-by: Ali Cheraghi <[email protected]>
Signed-off-by: Ali Cheraghi <[email protected]>
|
List what examples you tested with this. |
Comment on lines
+904
to
+927
| if (properties.limits.shaderFloat16) { | ||
| if (!vulkan12Properties.shaderSignedZeroInfNanPreserveFloat16) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderDenormPreserveFloat16) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderDenormFlushToZeroFloat16) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderRoundingModeRTEFloat16) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderRoundingModeRTZFloat16) | ||
| return nullptr; | ||
| } | ||
|
|
||
| if (properties.limits.shaderFloat64) { | ||
| if (!vulkan12Properties.shaderSignedZeroInfNanPreserveFloat64) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderDenormPreserveFloat64) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderDenormFlushToZeroFloat64) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderRoundingModeRTEFloat64) | ||
| return nullptr; | ||
| if (!vulkan12Properties.shaderRoundingModeRTZFloat64) | ||
| return nullptr; |
There was a problem hiding this comment.
Denorm and RTZ are not all true on the RTX 3060
Comment on lines
905
to
+991
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderSignedZeroInfNanPreserveFloat32", | ||
| "value": true, | ||
| "expose": "DISABLE" | ||
| "expose": "REQUIRE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderSignedZeroInfNanPreserveFloat64", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderDenormPreserveFloat16", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderDenormPreserveFloat32", | ||
| "value": false | ||
| "value": true, | ||
| "expose": "REQUIRE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderDenormPreserveFloat64", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderDenormFlushToZeroFloat16", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderDenormFlushToZeroFloat32", | ||
| "value": false | ||
| "value": true, | ||
| "expose": "REQUIRE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderDenormFlushToZeroFloat64", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderRoundingModeRTEFloat16", | ||
| "value": false, | ||
| "comment": ["ROADMAP2024 but no good support yet"] | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderRoundingModeRTEFloat32", | ||
| "value": false, | ||
| "comment": ["ROADMAP2024 but no good support yet"] | ||
| "value": true, | ||
| "expose": "REQUIRE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderRoundingModeRTEFloat64", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderRoundingModeRTZFloat16", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderRoundingModeRTZFloat32", | ||
| "value": false | ||
| "value": true, | ||
| "expose": "REQUIRE" | ||
| }, | ||
| { | ||
| "type": "bool", | ||
| "name": "shaderRoundingModeRTZFloat64", | ||
| "value": false | ||
| "value": false, | ||
| "expose": "DISABLE" |
There was a problem hiding this comment.
something went wrong here
devshgraphicsprogramming
added a commit
that referenced
this pull request
Mar 6, 2025
…evice-limits video: Revert some device limit changes from #829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: