warning: match expression looks like `matches!` macro --> src/grammar/symbol.rs:43:9 | 43 | / match self { 44 | | SymbolKind::Terminal(_) | SymbolKind::Regex(_) => true, 45 | | _ => false, 46 | | } | |_________^ help: try: `matches!(self, SymbolKind::Terminal(_) | SymbolKind::Regex(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

warning: returning the result of a `let` binding from a block --> src/grammar/raw.rs:44:17 | 43 | let entry = (rule.name.clone(), graph.add_node(rule.name.clone())); | ------------------------------------------------------------------- unnecessary `let` binding 44 | entry | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 43 ~ 44 ~ (rule.name.clone(), graph.add_node(rule.name.clone())) |

warning: you are using an explicit closure for copying elements --> src/grammar/graph.rs:79:20 | 79 | out_deg == scc.iter().map(|n| *n).collect() | ^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `scc.iter().copied()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default

warning: called `map(..).flatten()` on `Iterator` --> src/grammar/graph.rs:76:14 | 76 | .map(|nx| self.graph.neighbors(*nx)) | ______________^ 77 | | .flatten() | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|nx| self.graph.neighbors(*nx))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `#[warn(clippy::map_flatten)]` on by default

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/grammar/graph.rs:62:33 | 62 | fn is_trap_loop(&self, scc: &Vec<NodeIndex>) -> bool { | ^^^^^^^^^^^^^^^ help: change this to: `&[NodeIndex]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/grammar/graph.rs:59:12 | 59 | Ok(&self) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: match expression looks like `matches!` macro --> src/grammar/alt.rs:52:9 | 52 | / match self.invoke_limit { 53 | | Limit::Unlimited => false, 54 | | _ => true, 55 | | } | |_________^ help: try: `!matches!(self.invoke_limit, Limit::Unlimited)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `#[warn(clippy::match_like_matches_macro)]` on by default

warning: associated function `new` is never used --> src/regex.rs:20:8 | 19 | impl Regex { | ---------- associated function in this implementation 20 | fn new(input: &str) -> Self { | ^^^

warning: method `children_len` is never used --> src/parse_tree/tree.rs:21:19 | 12 | impl<T> ParseTree<T> { | -------------------- method in this implementation ... 21 | pub(crate) fn children_len(&self) -> usize { | ^^^^^^^^^^^^

warning: method `name` is never used --> src/grammar/symbol.rs:27:12 | 23 | impl SymbolKind { | --------------- method in this implementation ... 27 | pub fn name(&self) -> Option<&str> { | ^^^^ | = note: `#[warn(dead_code)]` on by default

warning: type `grammar::symbol::SymbolKind` is more private than the item `grammar::checked::ReduceOutput::NonTerminal::syms` --> src/grammar/checked.rs:16:9 | 16 | syms: Vec<SymbolKind>, | ^^^^^^^^^^^^^^^^^^^^^ field `grammar::checked::ReduceOutput::NonTerminal::syms` is reachable at visibility `pub` | note: but type `grammar::symbol::SymbolKind` is only usable at visibility `pub(crate)` --> src/grammar/symbol.rs:7:1 | 7 | pub(crate) enum SymbolKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: type `grammar::symbol::SymbolKind` is more private than the item `generator::TreeGenerator::generate` --> src/generator.rs:44:5 | 44 | pub fn generate<R: Rng, S: ToString>(&self, start: S, rng: &mut R) -> ParseTree<SymbolKind> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `generator::TreeGenerator::generate` is reachable at visibility `pub` | note: but type `grammar::symbol::SymbolKind` is only usable at visibility `pub(crate)` --> src/grammar/symbol.rs:7:1 | 7 | pub(crate) enum SymbolKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default

warning: unused variable: `comma` --> /home/runner/work/bnfgen/bnfgen/target/debug/build/bnfgen-425e20e80eb4f7df/out/parser.rs:1636:9 | 1636 | (_, comma, _): (usize, Option<Token>, usize), | ^^^^^ help: if this is intentional, prefix it with an underscore: `_comma` | = note: `#[warn(unused_variables)]` on by default

warning: unused import: `LexicalError` --> src/utils.rs:3:20 | 3 | use crate::token::{LexicalError, Token}; | ^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/