Erc20 lesson update 19nov #268
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ] | ||
| }, | ||
| { | ||
| "question": "How many methods are required by the ERC-20 standard to achieve the necessary functionality for a token contract?", |
There was a problem hiding this comment.
@wolovim, @ happysingh pointed out to me the inaccuracy of this answer, and the text in the tutorial where it stems from. He wanted to do a PR and fix it, but is waiting for permissions for the repo.
There was a problem hiding this comment.
@elPiablo this is a break from the current policy to give this level of repo permissions to Core Team members. not strictly opposed to adjusting that, but worth a quick convo in discord. if we don't grant further permissions, one alternative is to merge your work, then happy can follow up with a quick PR of his own, from his fork of the codebase.
There was a problem hiding this comment.
Hey @wolovim
I have six tasks on the list here, but we can settle for the first five. Item number 6 is a generic question about partners we need to answer at some stage ASAP, but this tutorial is not dependent on it to be merged (original PR message for clarity => #268 (comment))
You have quite a bit to get here, but I planned the commits before starting on them, so I hope you experience them cleanly and succinctly.
Have fun! 😄
There was a problem hiding this comment.
@elPiablo this is a break from the current policy to give this level of repo permissions to Core Team members. not strictly opposed to adjusting that, but worth a quick convo in discord. if we don't grant further permissions, one alternative is to merge your work, then happy can follow up with a quick PR of his own, from his fork of the codebase.
yeah, I just sent Happy a message and advised that course of action :) (https://discord.com/channels/883478451850473483/1171849215702483044/1176647550632210532)
|
@Markkos89 can you debug the hydration errors on this branch, please? Cheers! |
Note: with piablo saw that removing some comments that were invalidating some eslint rules in the |
PR aims to get Create your first ERC-20 with Foundry lesson fully ready for production in 5 to 6 stages/commits
update solidity pragma statements; redeploy contact; update terminal output code; renew Etherscan screenshots (public/assets/lessons) (see commits: 218e058 and 310cdae)
2. add 1/4 and 2/4 of checkpoint questions (see commit: c2d7cc5)
3. add 3/4 and 4/4 of checkpoint questions (see commit: 0b79dec )
4. add final quiz (see commit: 21b61b4)
5. add outro final paragraph for learners' next possible steps including other tracks and https://handbook.developerdao.com/ (see commit: )
- [ ] 6. Need to get info on POKT (Nodies and Grove) - there doesn't seem to be a shared public URL for an endpoint. And need to get in touch with Zerion to give us a little guide on what it is and how to set up. (see issue: #269 (comment))we have an open issue for this, so we can ignore it in the context of this PR