Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Commit

Permalink
Check for 80-char line length limit
Browse files Browse the repository at this point in the history
This is what is already written in the coding conventions; the
Checkstyle configuration was just wrong. The change required some
adjustments in FlowchardStateGermany#getNextState.
  • Loading branch information
Denis Washington committed Nov 10, 2014
1 parent 6a041ed commit 0d0b377
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion google_checks.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<property name="message" value="Avoid using corresponding octal or Unicode escape."/>
</module>
<module name="LineLength">
<property name="max" value="100"/>
<property name="max" value="80"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
</module>
<module name="AvoidStarImport"/>
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/de/ddb/pdc/core/FlowChartStateGermany.java
Original file line number Diff line number Diff line change
Expand Up @@ -294,13 +294,13 @@ public Question getQuestion() throws NoSuchElementException {
@Override
public FlowChartState getNextState(Answer answer)
throws IllegalStateException {
if (this.unconditionalNextState != null) {
return this.unconditionalNextState.getNextState(answer);
} else if (this.positiveNextState != null && this.negativeNextState != null) {
if (unconditionalNextState != null) {
return unconditionalNextState.getNextState(answer);
} else if (positiveNextState != null && negativeNextState != null) {
if (answer == Answer.YES) {
return this.positiveNextState;
return positiveNextState;
} else {
return this.negativeNextState;
return negativeNextState;
}
}
throw new IllegalStateException();
Expand Down

0 comments on commit 0d0b377

Please sign in to comment.