Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --use-scoped-token with --use-scoped-token=always|never #154

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 6, 2024

No description provided.

@colemickens
Copy link
Member

Do we even want to support this? Is this just for internal testing to be able to test with a coarser token?

@grahamc
Copy link
Member Author

grahamc commented Nov 6, 2024

I think @cole-h wanted it for testing(?), but then yesterday we tried to use it to get out of a bind where the closure was pushed to to slice for flake A, and the flake pushed to flake B. It didn't work.

@colemickens
Copy link
Member

do we know what didn't work? I don't see how just inverting the flag "fixes" it if something (else?) is broken.

@grahamc grahamc changed the title Replace --use-scoped-token with --no-scoped-token Replace --use-scoped-token with --use-scoped-token=always|never Nov 6, 2024
@grahamc grahamc enabled auto-merge November 6, 2024 22:04
@cole-h
Copy link
Member

cole-h commented Nov 6, 2024

The thing that's broken here is it appears there's no way to turn this from false to true with the flag (i.e. you can't pass --use-scoped-token false to disable it -- we suggested trying this, and it didn't work). Inverting it means you can at least pass --no-scoped-token to disable the default of "yes, use a scoped token".

@grahamc
Copy link
Member Author

grahamc commented Nov 6, 2024

@cole-h thanks, yeah, Cole and I chatted on a call and came around to it. He suggested using an enum and not a flag, which I agreed with, so I updated the PR.

@grahamc grahamc merged commit 46c2856 into main Nov 6, 2024
8 checks passed
@grahamc grahamc deleted the graham/fh-440-fh-apply-cant-turn-off-use-scoped-token branch November 6, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants