Fix sheet height locking too early for filter help

src/app/dim-ui/Sheet.tsx

@@ -226,9 +226,14 @@
       if (sheetContents.current.clientHeight > 0) {
         setFrozenHeight(sheetContents.current.clientHeight);
       } else {
-        setTimeout(() => {
-          sheetContents.current && setFrozenHeight(sheetContents.current.clientHeight);
-        }, 500);
+        const setHeight = () => {
+          if (!sheetContents.current || sheetContents.current.clientHeight === 0) {
+            return false;
+          }
+          setFrozenHeight(sheetContents.current.clientHeight);
+          return true;
+        };
+        tryWithBackoff(setHeight);
       }
     }
   }, [freezeInitialHeight, frozenHeight]);
@@ -321,3 +326,16 @@
     </Portal>
   );
 }
+
+function tryWithBackoff(callback: () => boolean, timeout: number = 500, limit: number = 5_000) {
+  if (timeout > limit) {
+    return;
+  }
+  setTimeout(() => {
+    const res = callback();
+    if (res) {
+      return;
+    }
+    tryWithBackoff(callback, timeout * 1.25);
+  }, timeout);
+}

src/app/search/SearchBar.tsx

@@ -545,21 +545,25 @@ function SearchBar(
         </LayoutGroup>
 
         {filterHelpOpen && (
-          <Sheet
-            onClose={() => setFilterHelpOpen(false)}
-            header={
-              <>
-                <h1>{t('Header.Filters')}</h1>
-                <UserGuideLink topic="Item-Search" />
-              </>
-            }
-            freezeInitialHeight
-            sheetClassName={styles.filterHelp}
-          >
-            <Suspense fallback={<Loading message={t('Loading.FilterHelp')} />}>
+          <Suspense fallback={<Loading message={t('Loading.FilterHelp')} />}>
+            {/* Because FilterHelp suspends, the entire sheet will suspend while it is loaded.
+             * This stops us having issues with incorrect frozen initial heights as it will
+             * get locked to the fallback height if we don't do this.
+             */}
+            <Sheet
+              onClose={() => setFilterHelpOpen(false)}
+              header={
+                <>
+                  <h1>{t('Header.Filters')}</h1>
+                  <UserGuideLink topic="Item-Search" />
+                </>
+              }
+              freezeInitialHeight
+              sheetClassName={styles.filterHelp}
+            >
               <LazyFilterHelp />
-            </Suspense>
-          </Sheet>
+            </Sheet>
+          </Suspense>
         )}
 
         {autocompleteMenu}