Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: [potigol] - implementação qual_tipo #528

Merged
merged 4 commits into from
Oct 29, 2023
Merged

WIP: [potigol] - implementação qual_tipo #528

merged 4 commits into from
Oct 29, 2023

Conversation

pablotdv
Copy link
Contributor

@pablotdv pablotdv commented Oct 17, 2023 •
edited
Loading

resolve #529

@samuelrvg samuelrvg added the em andamento Não está pronto ainda label Oct 17, 2023
leonelsanchesdasilva
leonelsanchesdasilva requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@leonelsanchesdasilva leonelsanchesdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está no caminho certo. Pedi alguns ajustes.

fontes/avaliador-sintatico/dialetos/potigol/avaliador-sintatico-potigol.ts Outdated Show resolved Hide resolved
fontes/avaliador-sintatico/dialetos/potigol/avaliador-sintatico-potigol.ts Outdated Show resolved Hide resolved
fontes/avaliador-sintatico/dialetos/potigol/avaliador-sintatico-potigol.ts Outdated Show resolved Hide resolved
@pablotdv
[potigol] - implementação qual_tipo
57d964f 
Ajustes QualTipo Potigol

Ajustes QualTipo Potigol

Ajustes QualTipo Potigol
leonelsanchesdasilva
leonelsanchesdasilva approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@leonelsanchesdasilva leonelsanchesdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito show. Parabéns pela primeira entrega!

@leonelsanchesdasilva leonelsanchesdasilva merged commit a7c6e40 into principal Oct 29, 2023
1 check passed
@leonelsanchesdasilva leonelsanchesdasilva deleted the vetores branch October 29, 2023 00:54
pablotdv
pablotdv commented Oct 29, 2023
View reviewed changes
testes/potigol/avaliador-sintatico.test.ts Outdated
@@ -35,7 +35,7 @@ describe('Avaliador sintático', () => {
expect(retornoAvaliadorSintatico.declaracoes).toHaveLength(1);
});

it('Sucesso - Operações encadeadas', () => {
it.only('Sucesso - Operações encadeadas', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelrvg esse it.only deveria continuar aqui?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablotdv Na branch principal esta normal, sem o .only pelo que ví aqui.

https://github.com/DesignLiquido/delegua/blob/449fb55ddeb245fb56c609184ee54e74226ef97d/testes/potigol/avaliador-sintatico.test.ts#L38C61-L38C61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelrvg samuelrvg samuelrvg left review comments

@leonelsanchesdasilva leonelsanchesdasilva leonelsanchesdasilva approved these changes

Assignees
No one assigned
Labels
em andamento Não está pronto ainda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implementação qual_tipo
3 participants
@pablotdv @samuelrvg @leonelsanchesdasilva