Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant DC verification #510

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

xJoskiy
Copy link
Contributor

@xJoskiy xJoskiy commented Jan 6, 2025

Add DC verification with constant predicactes, add violations highlights and minimization algorithm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/dc/model/dc.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/model/dc.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/parser/dc_parser.cpp Show resolved Hide resolved
src/core/algorithms/dc/parser/dc_parser.cpp Show resolved Hide resolved
src/core/util/kdtree.h Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/dc/verifier/dc_verifier.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/verifier/dc_verifier.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/verifier/dc_verifier.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/dc/parser/dc_parser.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/parser/dc_parser.cpp Outdated Show resolved Hide resolved
@xJoskiy xJoskiy force-pushed the DC-verification branch 2 times, most recently from ebd4eae to deaa199 Compare January 20, 2025 20:21
@xJoskiy xJoskiy changed the title WIP: Constant DC verification Constant DC verification Jan 20, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/dc/model/column_operand.h Outdated Show resolved Hide resolved
@xJoskiy xJoskiy force-pushed the DC-verification branch 3 times, most recently from a90e568 to 3d0b351 Compare January 25, 2025 10:07
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/dc/model/dc.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/parser/dc_parser.cpp Outdated Show resolved Hide resolved
src/core/algorithms/dc/parser/dc_parser.cpp Outdated Show resolved Hide resolved
@xJoskiy xJoskiy force-pushed the DC-verification branch 2 times, most recently from 488dc79 to d990653 Compare January 26, 2025 09:57
Now it is possible to pass an option that tells the
algorithm whether to collect violations or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant