Add ability to build with clang #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Petua41
force-pushed
the
clang-buildability
branch
7 times, most recently
from
4a57f13 to
9983606
Compare
Vdaleke
reviewed
Nov 28, 2024
chernishev
reviewed
Nov 28, 2024
Petua41
force-pushed
the
clang-buildability
branch
2 times, most recently
from
1464239 to
0e25aaf
Compare
Petua41
force-pushed
the
clang-buildability
branch
2 times, most recently
from
f25cff4 to
e0e2a18
Compare
Petua41
force-pushed
the
clang-buildability
branch
from
d4d9b5c to
9bc09e3
Compare
Add `set -e` in build.sh to stop build process on error
Add SYSTEM flag to add_subdirectory(".../googletest") in CMakeLists.txt
to supress warnings from the inside of googletest
Replace INSTANTIATE_TEST_CASE_P, which is deprecated, with INSTANTIATE_TEST_SUITE_P in NDVerifier tests
Mark unused fields as [[maybe_unused]], because clang produces warning that becomes an error in Debug mode. Use MAYBE_UNUSED macro, because g++ produces warning when [[maybe_unused]] macro is present, and clang -- when it isn't.
Convert double literals to model::DoubleType and model::IntType explicitly, because otherwise clang produces a warning, that becomes an error in debug mode
Add run_tests_clang action in core_tests.yml Also, work around clang-18 bug
- Check that column is numeric *before* casting it to INumericType in DataStats::GetMedianAD - Don't process empty vector in GetPartition in gfd_validation.cpp - Disable tests causing float-to-long cast when result is infinity
Add Clang installation guide to README.md
Use simple RAII wrapper of std::thread instead of std::jthread when the latter isn't implemented (which is the case in Apple Clang)
Use custom implementations of std::bitset::_Find_dirst and _Find_next when gcc intrinsics aren't availible Use some tricks with boost::dynamic_bitset in fd_tree_bitset to avoid GCC intrinsics _Find_first and _Find_next
Use std::chrono::high_resolution_clock instead of std::chrono::_V2::high_resolution_clock in fastod/util/timer.h, because symbol versioning is gcc-specific
Make GetByte function contexpr only if std::vector::operator[] is contexpr (which isn't on old versions of GCC)
Shift bitset 1 bit left in CreateDynamicBitset (fallback variant), as it done in main (gcc intrinsic) variant. Also, rename this function for clarity.
Use system_clock everywhere instead of mix of system_clock and high_resolution_clock in Cords::ExecuteInternal
Add instructions how to build boost with clang
Link clang build with libc++ instead of libstc++ in CI Also build boost with clang in CI
Don't violate implicit noexcept(true) in AutoJoinThread's destructor
Version 1.13.0 of googletest produces "narrowing conversion" warning due to a bug (issue #4206, google/googletest#4206) when building with Clang. This bug was fixed in 1.14.0 (commit 3044657, google/googletest@3044657)
Install all LLVM packages in install-clang action in CI, not only LLVM and Clang
Use concepts to test GCC intrinsics precence, instead of SFINAE
Use stable_sort instead of sort to avoid relying on unspecified behaviour (wheter sort preserves order of equal elements)
Sort pairs by value if frequencies are equal in Cords' FrequencyHandler::InitFrequencyHandler
Petua41
force-pushed
the
clang-buildability
branch
from
9bc09e3 to
7adcb42
Compare
Use reverse iterators to traverse set in reverse order, instead of messing with normal iterators
Disable alloc-dealloc-mismatch check as it's false positive on Ubuntu (see comment in CMakeLists.txt)
Remove comment about libc++abi in README
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to build with clang compiler (on linux):