Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUCVerifier with python bindings #290

Merged
merged 11 commits into from
Dec 9, 2023

Conversation

aartdem
Copy link
Contributor

@aartdem aartdem commented Nov 16, 2023

Completed PR #216
Fix naming, adapt to the current version of the project, add new tests, add default implementation for IndicesOption in UCCVerifier

@aartdem aartdem force-pushed the add-uccverifier branch 2 times, most recently from 4967e4e to d1a175d Compare November 16, 2023 21:33
@BUYT-1 BUYT-1 requested review from polyntsov and Mstrutov and removed request for Mstrutov and polyntsov November 20, 2023 17:43
src/core/algorithms/ucc/ucc_verifier/ucc_verifier.h Outdated Show resolved Hide resolved
src/core/algorithms/ucc/ucc_verifier/ucc_verifier.h Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/core/config/names.h Outdated Show resolved Hide resolved
src/core/algorithms/ucc/ucc_verifier/ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
@aartdem aartdem force-pushed the add-uccverifier branch 9 times, most recently from c1d7e9b to f19c488 Compare November 29, 2023 21:55
@aartdem aartdem requested a review from polyntsov November 29, 2023 21:57
src/core/algorithms/ucc/ucc_verifier/ucc_verifier.h Outdated Show resolved Hide resolved
src/core/algorithms/ucc/ucc_verifier/ucc_verifier.cpp Outdated Show resolved Hide resolved
src/core/config/common_option.h Outdated Show resolved Hide resolved
src/core/config/descriptions.h Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
@aartdem aartdem force-pushed the add-uccverifier branch 4 times, most recently from 71379a6 to 268f840 Compare December 6, 2023 00:40
@aartdem aartdem requested a review from polyntsov December 6, 2023 00:44
src/core/config/common_option.h Outdated Show resolved Hide resolved
src/core/config/thread_number/option.cpp Outdated Show resolved Hide resolved
src/core/algorithms/ucc/ucc_verifier/ucc_verifier.h Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/tests/test_ucc_verifier.cpp Outdated Show resolved Hide resolved
src/core/config/indices/option.h Show resolved Hide resolved
@aartdem aartdem requested a review from polyntsov December 6, 2023 23:59
@aartdem aartdem force-pushed the add-uccverifier branch 3 times, most recently from 72c5104 to c43eb56 Compare December 7, 2023 18:39
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/config/indices/option.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/config/indices/option.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/config/common_option.h Outdated Show resolved Hide resolved
src/core/config/common_option.h Outdated Show resolved Hide resolved
src/core/config/common_option.h Outdated Show resolved Hide resolved
src/core/config/common_option.h Outdated Show resolved Hide resolved
@aartdem aartdem force-pushed the add-uccverifier branch 3 times, most recently from 6100801 to 5f865ab Compare December 7, 2023 23:53
@polyntsov polyntsov merged commit 0eacddf into Desbordante:main Dec 9, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants