Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setup.py functionality to poetry for pre-check and package build and release. #275

Closed
ghost opened this issue Sep 22, 2022 · 4 comments · Fixed by #290
Closed

Move setup.py functionality to poetry for pre-check and package build and release. #275

ghost opened this issue Sep 22, 2022 · 4 comments · Fixed by #290
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Sep 22, 2022

I'm submitting a

[x] feature idea to research and discuss

This is split from #272

Current Behaviour:

Investigate and review the implication of changing the existing use of setup.py and using poetry instead for pre-check, package build, and release.

One thing I am not at all clear on is the documentation building for KGLab, and how that will need to be managed in a poetry env / process.

@ghost ghost mentioned this issue Sep 22, 2022
1 task
@ceteri ceteri assigned ceteri and ghost Nov 23, 2022
@ceteri ceteri added the enhancement New feature or request label Nov 23, 2022
@ceteri
Copy link
Collaborator

ceteri commented Nov 23, 2022

hi @jake-biolexis ,
i'm doing an initial impl on pyproject.toml since it will be required for the next update of pip

my impl could probably use some help :)

@jake-aft
Copy link
Contributor

jake-aft commented Dec 3, 2022

@ceteri i do not have permission to publish to test-pipy on kglab.

publishI am happy to assume that the poetry publish will work, as I think a lot of people use it.

Using poetry build I am getting builds at ~50 K with exclude of the rdf dir
Does that seem small to you or expected?

➜ kglab git:(poetry_build) ✗ ls -lh dist
-rw-r--r-- 1 jake staff 51K Dec 3 16:35 kglab-0.1.1a3-py3-none-any.whl
-rw-r--r-- 1 jake staff 45K Dec 3 16:35 kglab-0.1.1a3.tar.gz

@jake-aft jake-aft mentioned this issue Dec 4, 2022
@jake-aft
Copy link
Contributor

jake-aft commented Dec 4, 2022

Included in PR - #300

@jake-aft
Copy link
Contributor

@ceteri I think this can be closed as it should be addressed in #300 ?

@ghost ghost closed this as completed Feb 1, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants