Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation #272

Open
1 task done
Mec-iS opened this issue Sep 7, 2022 · 7 comments
Open
1 task done

Improve installation #272

Mec-iS opened this issue Sep 7, 2022 · 7 comments
Labels
good first issue Good for newcomers

Comments

@Mec-iS
Copy link
Contributor

Mec-iS commented Sep 7, 2022

I'm submitting a

  • feature request.

Current Behaviour:

Current installation is possible only with pip

Expected Behaviour:

It may be good for accessibility to provide installation via python-poetry and suggest Anaconda in the README for people that prefer conda environments

cc: @ceteri

@Mec-iS Mec-iS added the good first issue Good for newcomers label Sep 7, 2022
@ceteri
Copy link
Collaborator

ceteri commented Sep 16, 2022

Outstanding, using poetry would be a nice improvement for kglab !

We have support for conda (especially for the RAPIDS integration, e.g., cuGraph, etc.) and there's a brief mention in the README for that.

@ghost
Copy link

ghost commented Sep 17, 2022

@ceteri @Mec-iS are you wanting to move the KGLab package build to poetry?

@Mec-iS
Copy link
Contributor Author

Mec-iS commented Sep 17, 2022

we would like to provide different alternatives for installation, one of which can be poetry. ideally the requirements definition should be same between requirements.txt and pyproject.toml

@ceteri
Copy link
Collaborator

ceteri commented Sep 17, 2022

Something less 2008-ish :)

It gets interesting to support a wider range of alternatives for installation, given that the RAPIDS parts can only be installed with conda which is specifically configured through the NVIDIA release selector https://rapids.ai/start.html#get-rapids

That said, we don't want to become a conda-only package.

@ghost
Copy link

ghost commented Sep 17, 2022

I'll do a bit of poking around and come back with some ideas for pipenv and poetry

@ghost
Copy link

ghost commented Sep 22, 2022

I will update the readme with install instructions for poetry and pipenv to install as a pypi package to use in a project.
I will also make updates to install the dev/test tutorial requirements with poetry and pipenv.
I'll create a pyproject.toml for poetry and a Pipfile for pipenv.

Created #275 to split changes

@jake-aft
Copy link
Contributor

jake-aft commented Dec 3, 2022

This is the related PR for this issue
#299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants