Remove the legacy Gradle build lifecycle API #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finished actions has been deprecated for a while so we can remove it
jmatsu
changed the title
jmatsu
changed the title
jmatsu
force-pushed
the
fix/drop_build_listener
branch
from
53a4505 to
e3ec808
Compare
jmatsu
requested review from
a team and
satsukies
and removed request for
a team
satsukies
requested changes
Feb 16, 2023
| @@ -116,12 +116,9 @@ abstract class UploadArtifactTask extends DefaultTask { | |||
| if (!sent && (Config.shouldOpenAppDetailAfterUpload() || response.typedResponse.application.revision == 1)) { | |||
| BrowserUtils.openBrowser "${project.deploygate.endpoint}${response.typedResponse.application.path}" | |||
| } | |||
| } catch (HttpResponseException e) { | |||
| } catch (Throwable e) { | |||
There was a problem hiding this comment.
I understand to this change behavior to send to server always.
So, I ask to reason to why aggregate to super class.
There was a problem hiding this comment.
We never allow any failure when notifying lifecycle events to the server so it's better to suppress Throwable rather than specifying specific exceptions.
There was a problem hiding this comment.
OK, I understand to this change is necessary 👍
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #147 and #148
As for buildFinished, we have not used this action for a while. We can safely delete this.