Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code + update documentation #1511

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Sep 16, 2024

Description

Remove deprecated code and document the endpoints removed in apiserver.

Addressed Issue

#1428

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Copy link

codacy-production bot commented Sep 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+17.96% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c09d23d) 201 132 65.67%
Head commit (9c6a0c6) 6890 (+6689) 5762 (+5630) 83.63% (+17.96%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1511) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro
Copy link
Member

nscuro commented Sep 17, 2024

Please also consider adding the removed endpoints to upgrading.md so existing users are made aware of this when upgrading to 0.6.0.

@sahibamittal sahibamittal marked this pull request as ready for review September 17, 2024 10:53
@sahibamittal sahibamittal added this to the 0.6.0 milestone Sep 17, 2024
@nscuro nscuro merged commit 8a064f2 into main Sep 18, 2024
13 checks passed
@nscuro nscuro deleted the issue-1428-remove-deprecated-code branch September 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants