Refactor meta analyzer to always fetch integrity data #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
2 tasks
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
nscuro
force-pushed
the
issue-1306-fix
branch
3 times, most recently
from
6cb091c
to
f9fd919
Compare
nscuro
force-pushed
the
issue-1306-fix
branch
from
f9fd919
to
7613870
Compare
The API server no longer specified whether only the latest version, only integrity metadata, or both should be fetched. Instead, we now always try to fetch both, relying on caching to prevent unnecessary repetitive calls to remote repositories. To further reduce remote calls being made, we now also use caching for when a given repository does not contain the analyzed component. Previously, only successful retrievals would be cached. Additionally, populates the MDC to include: * The PURL of the component being analyzed * The identifier of the repository being used Signed-off-by: nscuro <[email protected]>
nscuro
force-pushed
the
issue-1306-fix
branch
from
7613870
to
72e09d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors meta analyzer to always fetch integrity data.
The API server no longer specified whether only the latest version, only integrity metadata, or both should be fetched.
Instead, we now always try to fetch both, relying on caching to prevent unnecessary repetitive calls to remote repositories.
To further reduce remote calls being made, we now also use caching for when a given repository does not contain the analyzed component. Previously, only successful retrievals would be cached.
Additionally, populates the MDC to include:
Addressed Issue
Relates to #1306
Additional Details
API server PR: DependencyTrack/hyades-apiserver#846
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly