Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Webhook alert token and new user alerts #1338

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 17, 2024

Description

This PR adds two new notification types (user_created and user_deleted) and the possibility of setting a token on the webhook alert.

Addressed Issue

Backport change #1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-Authored-By: Marlon Pina Tojal <[email protected]>
@sahibamittal sahibamittal force-pushed the backport-new-user-notifications branch from edc00c6 to 36e4e70 Compare June 17, 2024 15:15
@sahibamittal sahibamittal marked this pull request as ready for review June 17, 2024 15:25
Copy link

codacy-production bot commented Jun 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.61% (target: -1.00%) 68.18% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (50603fc) 172 140 81.40%
Head commit (c26b1cb) 6841 (+6669) 5747 (+5607) 84.01% (+2.61%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1338) 22 15 68.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jun 17, 2024
@nscuro nscuro added this to the 0.5.0 milestone Jun 17, 2024
@nscuro nscuro changed the title Backport : Webhook alert token and new user alerts Port: Webhook alert token and new user alerts Jun 18, 2024
@nscuro nscuro merged commit 0012f26 into main Jun 18, 2024
12 of 13 checks passed
@nscuro nscuro deleted the backport-new-user-notifications branch June 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants