Postpone deprecation of unauthenticated access to Badge API #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecation notice for unauthenticated access to the Badge API, as the use of API keys for authenticated access comes with risks too that the maintainer of the DT instance has to weigh against the use of unauthenticated access which does not use API keys. Signed-off-by: Kirill.Sybin <[email protected]>
|
@SaberStrat Did you mean to make more changes? If not, please change the PR to ready for review. |
|
Thanks for the review! I just wanted to create a corresponding issue and PR for the frontend first to have everything ready, but just for organization's sake. Both should be done for the targeted release though. The order in which these two are merged in their corresponding repos doesn't really matter of course. Here's the frontend issue: DependencyTrack/frontend#1127. Will try to create the PR later today or tomorrow. |
SaberStrat
deleted the
feature/postpone-deprecation-of-unauthenticated-badges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecation notice for unauthenticated access to the Badge API, as the use of API keys for authenticated access comes with risks too that the maintainer of the DT instance has to weigh against the use of unauthenticated access which does not use API keys.
Description
Addressed Issue
Closes #4500
Additional Details
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly