-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Build order support #18
Open
reypader
wants to merge
82
commits into
Dentosal:master
Choose a base branch
from
reypader:build-order-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-Windows platforms
To be concise, only the condition must be checked to decide whether the action would be done. Checking `can_afford` is the responsibility of the action.
This would allow easier analysis of expansion location resource density
Gas would be prioritized over minerals when allocating excess workers.
This relies on Python's falsy/truthy treatment of integers.
This would simplify the build order declaration by instead declaring how many workers is desired. This works under the assumption that in the early game, the bot needs to keep making workers.
The commands are not coupled with the build order anyway. Fixes Dentosal#7
This will closely resemble what is in sc2client-api
# Conflicts: # examples/zerg_rush.py # sc2/bot_ai.py # sc2/data.py # sc2/ids/ability_id.py
reypader
force-pushed
the
build-order-support
branch
from
February 1, 2018 07:03
ebfa15a
to
4b692de
Compare
reypader
force-pushed
the
build-order-support
branch
from
February 1, 2018 07:06
4b692de
to
a8ceab2
Compare
# Conflicts: # examples/zerg_rush.py # sc2/ids/ability_id.py # sc2/ids/buff_id.py
Still marked as WIP because as of the moment, conditions are very verbose. That is, we have to specify a lot of conditions to make sure that a build order step is executed at the right time. The current implementation in this PR, in my view is rather naive. What I'm trying to achieve is a build order that satisfies the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented build order to be as close as possible to what a human readable build order looks like.