Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing and remove unused code #257

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Add testing and remove unused code #257

wants to merge 26 commits into from

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Sep 26, 2024 •
edited
Loading

Ref https://app.asana.com/0/1204880927741389/1208159470102409/f

  • Added Playwright tests for the front-end leaflet upload process.
  • Replaced TestCase with pytest for testing.
  • Introduced YNR API key to bypass rate limiting.
  • Resolved security vulnerability by upgrading Django from 4.2.15 to 4.2.16.
  • Updated CI configuration to fix persistent issues with Pipenv.
  • Add overall test coverage
  • Misc bug fixes

@VirginiaDooley VirginiaDooley changed the base branch from master to upgrades202409-part2 September 26, 2024 15:27
@VirginiaDooley VirginiaDooley changed the base branch from upgrades202409-part2 to master September 26, 2024 15:30
@VirginiaDooley VirginiaDooley changed the base branch from master to upgrades202409-part2 September 26, 2024 15:31
@VirginiaDooley VirginiaDooley changed the base branch from upgrades202409-part2 to master September 26, 2024 15:39
@VirginiaDooley VirginiaDooley changed the base branch from master to upgrades202409-part2 September 26, 2024 15:53
@VirginiaDooley VirginiaDooley force-pushed the hotfix/fix-staging-uploads branch 2 times, most recently from cc6d803 to e4e2edf Compare September 30, 2024 13:42
@VirginiaDooley VirginiaDooley force-pushed the upgrades202409-part2 branch 5 times, most recently from 21b3792 to 5f8cebb Compare October 1, 2024 12:29
Base automatically changed from upgrades202409-part2 to master October 1, 2024 13:58
@VirginiaDooley VirginiaDooley force-pushed the hotfix/fix-staging-uploads branch 3 times, most recently from 9551458 to 38adb43 Compare October 2, 2024 14:14
@VirginiaDooley VirginiaDooley changed the title Hotfix/fix staging uploads Test frontend with Playwright Oct 2, 2024
@VirginiaDooley VirginiaDooley force-pushed the hotfix/fix-staging-uploads branch 11 times, most recently from 421dfdf to 15c41cd Compare October 8, 2024 21:38
@symroe symroe force-pushed the hotfix/fix-staging-uploads branch 3 times, most recently from 202b420 to 88b1581 Compare November 12, 2024 17:34
symroe and others added 26 commits November 15, 2024 15:22
@symroe
Install Playwright
2d5ca67
@symroe
Test frontend
7ad6b10
@VirginiaDooley @symroe
Handle cases where no initial date exists
6217477
@VirginiaDooley @symroe
Use YNR auth token to address rate limiting
a0508de
@VirginiaDooley @symroe
Test redirect after leaflet creation
395ea78
@VirginiaDooley @symroe
Install and use pytest
456fca4
@VirginiaDooley @symroe
Convert tests to use pytest
4a8e3f5
@VirginiaDooley @symroe
Convert image_editing tests from TestCase to pytest
abd4b4a
@VirginiaDooley @symroe
Remove unused code
871fda9
@VirginiaDooley @symroe
Return a relative path to address path traversal attempt
9da376a
@VirginiaDooley @symroe
Saving an LeafletImage requires an image file and name
5f91235
@VirginiaDooley @symroe
Adjust tests after asking pytest to use testing.py
b46d2cc 
I think this change is required following the change to
use pytest and testing.py settings that use the `test_media`
path for sourcing test images.
@VirginiaDooley @symroe
Add pytest coverage for core forms
49fe17a
@VirginiaDooley @symroe
Add pytest coverage for core models
5e1b270
@symroe
Remove bulk of analysis app
703d9e6 
Keeping the models for legacy data migration reasons
@VirginiaDooley @symroe
Add pytest coverage for api views
767b789
@VirginiaDooley @symroe
Add pytest coverage for api feeds
85bdf20
@VirginiaDooley @symroe
Update deploy instructions
6e56553
@VirginiaDooley @symroe
Handle multiple parties returned
772e36d 
Handles https://democracy-club-gp.sentry.io/share/issue/ad779fe45c134ffd8b383cc44395f11b/
@VirginiaDooley @symroe
Convert Person model tests from TestCase to pytest
146218c
@VirginiaDooley @symroe
Fix status message
9362d00
@VirginiaDooley @symroe
Remove codecov arguements; TODO: config for codecov
3042d04
@VirginiaDooley @symroe
Clear cache
a6c6408
@VirginiaDooley @symroe
Remove six; no longer used
cb51f0a
@VirginiaDooley @symroe
Use live_server from pytest-django to start server
6844a8b
@symroe
Remove bulk of constituencies app
a6630f0 
Keep model for legacy migration needs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symroe symroe symroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirginiaDooley @symroe