Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few minor fixes to ballots template #109

Merged
merged 3 commits into from
Nov 4, 2024
Merged

a few minor fixes to ballots template #109

merged 3 commits into from
Nov 4, 2024

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Oct 30, 2024

This is another little "leave things a little better than you found them" PR, just fixing a couple of things I noticed while working on PR #108

The diff looks big due to an indenting change, but if you look at:

That should make it easier to review.

Lets ignore updating the translations for now refs #110

this stops us from showing multiple headers
that just say "candidates" when there are >1 ballots
without SOPN yet.
this allows the href="#target" links to work
whether there is a SOPN yet or not
@chris48s chris48s requested a review from symroe October 30, 2024 15:33
@chris48s chris48s mentioned this pull request Oct 30, 2024
@chris48s chris48s merged commit 338928b into main Nov 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants