Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/impact numbers #853

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Hotfix/impact numbers #853

merged 4 commits into from
Oct 10, 2024

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Jul 16, 2024

This PR updates the impact metrics following the 2024 General Election, includes a security patch for Django, and adjusts indentation.

  • Updates postcode search number
  • Removes number of reminders sent in 2019
  • Updates more likely to vote

Screenshot 2024-10-10 at 9 14 25 AM
Screenshot 2024-10-10 at 9 14 09 AM


Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (179b497) to head (892947c).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files          28       28           
  Lines         566      566           
=======================================
  Hits          440      440           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -26,8 +26,7 @@ <h2>Our impact in numbers</h2>
and local elections.</p>

<ul class="ds-switcher ds-showcase" style="--gridCellMin: 16ch; --gridGap: 1.5rem;">
<li><strong>219m</strong> reminders to vote sent via partnerships in&nbsp;2019</li>
<li><strong>3.5m</strong> people used our services in the last general election</li>
<li><strong>14m</strong> people used our services in the 2024 general election</li>
<li><strong>83%</strong> of users say that our services make them more likely to&nbsp;vote</li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmk01 Regarding "more likely to vote", with the addition of the "no change" option, this number has become more complicated to report. Do we want to revert to 'found useful'? If I average the numbers from WDIV and WCIVF, we are at 86%.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, move back to 'found useful'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific question is 'did you find what you were looking for?' Is there's a better way to summarise this?
"85% of users found the information they needed", or similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this change.

@VirginiaDooley VirginiaDooley marked this pull request as ready for review July 17, 2024 10:52
@VirginiaDooley VirginiaDooley force-pushed the hotfix/impact-numbers branch 2 times, most recently from 045f073 to 714f4a3 Compare October 9, 2024 11:08
@pmk01 pmk01 merged commit 68155bd into master Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants