Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/681 remove need for having input config as input to analysisfactoryrun #682

Open
wants to merge 5 commits into
base: feat/660-create-an-example-to-run-damages-and-losses-without-input-files
Choose a base branch
from
Open

Feat/681 remove need for having input config as input to analysisfactoryrun #682

wants to merge 5 commits into from

Conversation

ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Jan 10, 2025 •
edited
Loading

Issue addressed

Solves #681

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

  • Remove redundant ra2ce_input as input to AnalysisRunnerFactory.run()
  • Improve the logic in AnalysisRunnerFactory.get_supported_runners() to check if each provided analysis has a supported runner
  • Add can_run() as non-static method to SimpleAnalysisRunnerBase
  • Adjust check on presence of hazard in DamagesAnalysisRunner.can_run()
  • Restructure tests to use AnalysisCollection

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@ArdtK ArdtK linked an issue Jan 10, 2025 that may be closed by this pull request
Remove need for having input_config is input to AnalysisFactory.run() #681
Open
@ArdtK ArdtK changed the base branch from master to feat/660-create-an-example-to-run-damages-and-losses-without-input-files January 10, 2025 11:24
@ArdtK ArdtK marked this pull request as ready for review January 13, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove need for having input_config is input to AnalysisFactory.run()
1 participant
@ArdtK