Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in if statements: 'is' vs '==' #194

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

LuukBlom
Copy link
Collaborator

Issue addressed

No issue

Explanation

I don't think these have resulted in catastrophic bugs yet, and might already be fixed in a branch somewhere.
But I get warnings when I compile FloodAdapt, so I thought why not just make a fork and fix them.
I think the changes are trivial, so let me know if you dissagree.
The import and formatting changes are due to ruff formatting and removing unused imports automatically, so that shouldn't have broken anything.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Copy link
Collaborator

@roeldegoede roeldegoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@roeldegoede roeldegoede merged commit cff84db into Deltares:FA_quadtree Apr 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants