Remove alerts instead of deactivating them #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the active state for an alert altogether, since it is no longer used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closing alert messages was a bit buggy; multiple items would be closed or all alerts would be hidden upon closing a single alert. Issues stemmed from the alerts state not being deeply reactive. We now simplified the alerts store by removing the
activeproperty, which was only used to "remove" alerts.Checklist
rel: new featurerel: improvementrel: fixesrel: ignoreSelect to
rel: ignoreif this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.