Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump schema version to 3 #1979

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bump schema version to 3 #1979

merged 1 commit into from
Dec 20, 2024

Conversation

visr
Copy link
Member

@visr visr commented Dec 20, 2024

Fixes #1978
In #1956 we forgot to update the schema version. Due to this line:

if version < ribasim.__schema_version__:

That means migration functions aren't called. This fixes that. I also added some extra comments on keeping them synced, and make the schema version checks a bit more consistent.

@visr visr requested a review from evetion December 20, 2024 15:18
@visr visr merged commit 0ecc373 into main Dec 20, 2024
28 checks passed
@visr visr deleted the bump-schema-version branch December 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in model-updater unrecognized column subnetwork_id doesn't get dropped at reading
2 participants