Allow missing 'Basin / time' data #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the imod coupler perspective, it's a bit onerous. Having to set all entries to NaN, except the first feels very specific. Ideally, I think the following would work as preparation for the coupling step: df = ribasim_model.basin.df
df.loc[df["node_id"].isin(coupled_node_ids), ["drainage", "infiltration"]] = np.nanRequires altering this in Ribasim: using Having zero as values if they are not defined here feels reasonable? |
visr
approved these changes
Feb 1, 2024
visr
changed the title
visr
changed the title
|
Judging from the test, this does exactly the right thing. I'll try and run this branch on one of my local models to be sure. |
Huite
added a commit
that referenced
this pull request
Feb 5, 2024
Missing is currently only allowed in the basin.time, thanks to #1028. This makes it consistent and allows it for basin.static as well (which is currently the reason a bunch of imod_coupler tests are failing). --------- Co-authored-by: Martijn Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very opportunistic fix to #1027
I'm not sure the
!isnan(value)check currently does anything meaningful to be honest?It's still a bit tedious to setup: to get it working I need to explicitly set the first date to zero, otherwise it triggers the following error:
error("Missing initial data for the Basin variable drainage")One way of dealing with this would be to initialize to zeros, and allow "unset" values for optionals. Not sure about it.
Needs a decision, and then we could add some simple tests.