Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in model-updater unrecognized column subnetwork_id doesn't get dropped at reading #1978

Closed
DanielTollenaar opened this issue Dec 19, 2024 · 0 comments · Fixed by #1979
Closed

Bug in model-updater unrecognized column subnetwork_id doesn't get dropped at reading #1978

DanielTollenaar opened this issue Dec 19, 2024 · 0 comments · Fixed by #1979
Labels
python Relates to one of the Ribasim python packages

Comments

@DanielTollenaar
Copy link
Contributor

Think it's time to update a schema-version.

Reading HWS.2024.12.0 in main (#1974) doesn't work as the model has a subnetwork_id doesn't get removed by migration before reading:

Image
@github-project-automation github-project-automation bot moved this to To do in Ribasim Dec 19, 2024
@visr visr mentioned this issue Dec 20, 2024
Merged
@visr visr added the python Relates to one of the Ribasim python packages label Dec 20, 2024
@visr visr closed this as completed in 0ecc373 Dec 20, 2024
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Relates to one of the Ribasim python packages
Projects
Ribasim
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump schema version to 3 Deltares/Ribasim
2 participants
@visr @DanielTollenaar