Remove warp point comp from map beacons #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The maps this'd cause trouble for would need prs open to fix them before this should be merged |
I can take a look through them Monday and sort out which ones would need it. |
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Apr 8, 2024
## Mirror of PR #991: [Adds pre-set warp points](DeltaV-Station/Delta-v#991) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-21 18:53:11 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-22 01:35:14 UTC</aside> <sup> `2ad986dddd855df06eb430b0640340b9f14a79ee` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Changes: Localization --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Title > Will work together with [this](DeltaV-Station/Delta-v#968) to create a cleaner more straightforward WP/Beacon mapping system. > > ## Why / Balance > Easier for mappers. Better for players </details> Co-authored-by: Velcroboy <[email protected]>
nearlyNonexistent
referenced
this pull request
in nearlyNonexistent/Horizon-Station
Apr 14, 2024
* Remove warp point comp from map beacons * Shorten a few names --------- Co-authored-by: Jeff <[email protected]>
VMSolidus
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
May 9, 2024
## Mirror of PR #968: [Remove warp point comp from map beacons](DeltaV-Station/Delta-v#968) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-16 14:13:15 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-28 04:53:19 UTC</aside> <sup> `40eeef24e7685a2bb2b2b35396fb546a38e96216` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Title > > ## Why / Balance > Makes things much cleaner. Currently we have Warp Point markers, Bombing Targets, and Map Beacons all with an overlapping function. (Also Warp points+Beacons markers but I'm ignoring those for this.) > > **Why it's messy** > Standard warp points and bombing targets can be used interchangeably. You can use a WP where you don't want a target, use a BT where you do. Beacons, on the other hand, don't have BT but double up as a WP. So, you either end up having to choose between a BT/WP or a beacon, or double up a location on the Ghost Warp menu. Additionally, just using beacons bloats the Warp Menu. > > Beacons can be moved by players. So, attaching either WP or BT to those is bad. Beacons are really nice, both for mappers and players but as long as they have WP, it causes conflict for mappers and/or bloat in the Ghost Warp menu. > > **Solution** > For Delta V we will use WP and BT to fill the Ghost Warp menu and Beacons for the Navmap. Problem solved/potential griefing, issues, etc. avoided, and no more Warp Menu bloat. > > ## Technical details > - Some maps will likely need to be adjusted for this change. > - Attempted to upstream this was denied. Solution proposed causes more work and less clear instructions for mappers. </details> Co-authored-by: Velcroboy <[email protected]> Co-authored-by: VMSolidus <[email protected]>
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
# Description This PR adds a new Language specific to the Harpy species, which is composed of syllable charts taken from Polish, Serbian, Greek, and Turkish. It uses Cambria as its font, which is modestly different from the standard font, but still reasonably readable. This also adds a Language menu trait that allows people to buy the language with a trait point. <details><summary><h1>Media</h1></summary> <p>  </p> </details> # Changelog :cl: - add: Harpies now have their own species-specific language, called Valyrian Standard - add: Valyrian Standard can now be bought as an extra language in the Traits menu. --------- Signed-off-by: VMSolidus <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]>
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Title
Why / Balance
Makes things much cleaner. Currently we have Warp Point markers, Bombing Targets, and Map Beacons all with an overlapping function. (Also Warp points+Beacons markers but I'm ignoring those for this.)
Why it's messy
Standard warp points and bombing targets can be used interchangeably. You can use a WP where you don't want a target, use a BT where you do. Beacons, on the other hand, don't have BT but double up as a WP. So, you either end up having to choose between a BT/WP or a beacon, or double up a location on the Ghost Warp menu. Additionally, just using beacons bloats the Warp Menu.
Beacons can be moved by players. So, attaching either WP or BT to those is bad. Beacons are really nice, both for mappers and players but as long as they have WP, it causes conflict for mappers and/or bloat in the Ghost Warp menu.
Solution
For Delta V we will use WP and BT to fill the Ghost Warp menu and Beacons for the Navmap. Problem solved/potential griefing, issues, etc. avoided, and no more Warp Menu bloat.
Technical details