Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RD mentions with Mystagogue #893

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

FluffiestFloof
Copy link
Contributor

About the PR

Fixes #890
Also the potted plant.

whats an rd even
@FluffiestFloof
Copy link
Contributor Author

FluffiestFloof commented Feb 23, 2024

Do we just not use the new markers?
Doesn't really matter they technically don't need more than one line

Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: Fluffiest Floofers <[email protected]>
@VMSolidus VMSolidus merged commit 63ec9e7 into DeltaV-Station:master Mar 5, 2024
10 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description
4 fixes:
- Fixed translators stopping to provide a language for a fraction of a
tick, causing the provided language to get de-selected when moving a
translator within your inventory (from hands to pocket or otherwise)
- Fixed translators not updating your languages when running out of
power (literally forgot to call UpdateEntityLanguages)
- Fixed language menu breaking after you reconnect to the server (the
issue is tricky, apparently all subscriptions made by ui controllers are
invalidated when the client switches from gameplay state to menu state
(the "you are disconnected" one), but never calls Initialize() for them
again, which means they can never re-create the same subscriptions...
Which explains why the ahelp menu was breaking for me after
reconnecting. All UI controllers that make event subscriptions are
affected by this bug)
- Fixed the language menu button not updating when you close the menu
manually.

# Changelog
:cl:
- fix: Fixed a couple issues with the language menu UI and translators.
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mystagogue's bedsheet is called "RD's Bedsheet"
3 participants