Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent probers from being unachored by gorilla gauntlets #824

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Feb 12, 2024

About the PR

Does what it says on the tin. If you try punting a prober, it'll shock you and some random shit around it

Why / Balance

Dangerous probers should stay dangerous unless destroyed or if glimmer is lowered.

Technical details

This makes it so AttemptMeleeThrowOnHitEvent is also raised on the entity thats getting thrown, and GlimmerReactiveSystem will cancel this event if glimmer is high enough, along with shocking the player and shooting (mostly harmless) lightning

Changelog
🆑

  • tweak: Glimmer probers now react violently to being hit by gorilla gauntlets if glimmer is above 500

@github-actions github-actions bot added the Changes: C# Changes any cs files label Feb 12, 2024
@DebugOk DebugOk mentioned this pull request Feb 12, 2024
@DebugOk
Copy link
Contributor Author

DebugOk commented Feb 12, 2024

It would be funny if it also destroyed the anomaly core in the gauntlet, but thats a bit too much effort for me

Copy link
Contributor

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished testing and reviewing this PR, it looks good to me.

@DebugOk DebugOk merged commit 7c62f5e into DeltaV-Station:master Feb 13, 2024
10 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Feb 13, 2024
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

InnatePsionicPowers needed to be moved from ComponentStartup to
MapInitEvent, which is a deceptively named event that ALSO functions
identically in use to ComponentStartup, except that it's safe to use for
entities that are mapped in, in addition to joining the round or being
spawned in. Whereas ComponentStartup isn't allowed to modify or add
components for any entity that is mapped(which includes Spawners
apparently).

This change allows for entities like Oracle and Sophia to make use of
InnatePsionicPowers, which is done by request from Rane, who for
mysterious reasons wishes for the two divine statues to be both
Prayable, and have the Noospheric Zap Power.

I have also verified by ingame testing that this does infact apply to
people who join after the map is initialized, as well as things
pre-existing on the map. So Oracle still gets her powers, while a
latejoining Mystagogue still gets his.

# Changelog

:cl:
- fix: InnatePsionicPowers now operates on MapInitEvent instead of
ComponentStartup, meaning that it can now be safely used on entities
that are mapped in instead of spawned.
- add: Oracle and Sophia are now recognized as Divine, and as such are
creatures that can be prayed to.
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants