Implement gridinv, proper #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
Changes: C#
|
I have read over all of the changes, and I believe there shouldn't be anything unintended in here except persistance being added. Oh well, fuck it. Sorry to everyone who hates gridinv. I would've loved to keep avoiding this. |
DeltaV-Bot
pushed a commit
that referenced
this pull request
Jan 21, 2024
|
persistence doesnt matter since you have to enable it in server config |
Yeah, just saying cause it got squashed in with the rest and I was too lazy to undo it |
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
# Description Just some regular cleanup of PsionicSystem and PsionicAbilitiesSystem. No refactoring today, just cleanup. Tomorrow I will serialize this shit, assuming this gets merged. No media because there's nothing to show. No changelog because this isn't playerfacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Implements gridinv, thats about it. (And also like 1 or 2 commits I apparently forgot)
Why / Balance
I really couldn’t keep avoiding this change if I wanted to keep doing upstream merges easily. I know I made a promise I would avoid this, but it was always a “For as long as possible” thing. I don’t like having to do this either, and I know some people really hate gridinv, and I’m sorry for that. The only way we could keep using the old system is if someone rewrote a ton of code, which I’m not willing to do.
Technical Details
Because I had to revert to October and repick all of the merges I did, I had like 1500 commits pending, which github didn’t like. Instead, I’ve squashed them all into 1 and applied that on top of the current master, fixing any conflicts that created. It seems to have worked, but I’ll still need time to review this pr just in case that resulted in anything weird.
Breaking changes
Its gridinv, any prs adding items/storage that specify stuff using the old values will need to be modified. But it shouldn’t™ break anything beyond that.
Changelog
Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑