Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluffy tail for felinids #433

Merged
merged 7 commits into from
Dec 30, 2023

Conversation

Adrian16199
Copy link
Contributor

@Adrian16199 Adrian16199 commented Nov 10, 2023

After 9 years. I finished it.

(Requires Phil's approval, will put it to ready for review as soon as he gets to see fully the fully finished PR)

About the PR

Adds a fluffy tail for felinids

Why / Balance

Because Fluffy tails and lack of love for felinids

Technical details

adds 5 files = 2 pngs, meta.json, ftl and yml.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    image

Breaking changes

Changelog

Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑

  • add: Added a fluffy tail for the felinids.

After 9 years. I finished it.

(Requires Phil's approval, will put it to ready for review as soon as he gets to see fully the fully finished PR)
@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Nov 10, 2023
Copy link
Contributor

github-actions bot commented Nov 10, 2023

RSI Diff Bot; head commit 8fb85d5 merging into d3028e7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Customization/Felinid/felinid_tails.rsi

State Old New Status
Felinid_fluffy_tail_full Added
felinid_fluffy_tail_rings Added

Edit: diff updated after 8fb85d5

@DebugOk
Copy link
Contributor

DebugOk commented Nov 10, 2023

Resources/Textures/DeltaV/Mobs/Customization/felinid_tails.rsi: felinid_fluffy_tail_rings: mismatching total durations between state directions: 2.4, 2.4, 1.8, 1.8

Make sure to fix your timing before marking it as ready

@Adrian16199
Copy link
Contributor Author

Resources/Textures/DeltaV/Mobs/Customization/felinid_tails.rsi: felinid_fluffy_tail_rings: mismatching total durations between state directions: 2.4, 2.4, 1.8, 1.8

Make sure to fix your timing before marking it as ready

Thing is, if im lookin at this right, then its the fact that half of it dont have the same amount of numbers and that was kinda intentional, the side sprites have less animations compared to the back sprites which is why I have given less numbers so it loops correctly thus why they are diferent, will it be an issue? I havent noticed any issues ingame when I was testing it. Unless its completely about somethin else that went over my head.

@DebugOk
Copy link
Contributor

DebugOk commented Nov 10, 2023

Resources/Textures/DeltaV/Mobs/Customization/felinid_tails.rsi: felinid_fluffy_tail_rings: mismatching total durations between state directions: 2.4, 2.4, 1.8, 1.8

Make sure to fix your timing before marking it as ready

Thing is, if im lookin at this right, then its the fact that half of it dont have the same amount of numbers and that was kinda intentional, the side sprites have less animations compared to the back sprites which is why I have given less numbers so it loops correctly thus why they are diferent, will it be an issue? I havent noticed any issues ingame when I was testing it. Unless its completely about somethin else that went over my head.

It's a test fail so yes, it's an issue.

Just have the speeds be consistent, use the same sprite several times for all I care

@Adrian16199
Copy link
Contributor Author

Well hoppity damn, understandable. 👍

@DebugOk
Copy link
Contributor

DebugOk commented Nov 10, 2023

Well hoppity damn, understandable. 👍

I'm not too familiar with the sprite system without looking at the code, but I suppose they wouldn't have that check without reason

Updated meta.json to include all numbers to be equal.
Updated PNG to allow updated numbers to have actual sprites and not just empty sprites.
@leonardo-dabepis
Copy link
Contributor

in terms of sprite work, I'm having a hard time seeing what the sprites look like. I would like to see a screenshot of these in the dev environment and animated before I approve. It's good to make more customization options for felinids though

@leonardo-dabepis
Copy link
Contributor

After seeing a clip of the tail and markings animated on Discord, I would like the stripes animation to be changed. Particularly from the back view of it, the stripes look visually unclear while animated. The baseline fluffy tail sprite looks fine though. If you want, I can help you out with making the stripes look clearer on Discord.

@Adrian16199
Copy link
Contributor Author

It would be my pleasure if you could help truly.

@Adrian16199 Adrian16199 marked this pull request as ready for review December 30, 2023 21:26
@Colin-Tel Colin-Tel merged commit 5bf246c into DeltaV-Station:master Dec 30, 2023
12 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Dec 30, 2023
DebugOk referenced this pull request in DebugOk/Delta-v Jan 20, 2024
* Fluffy tail for felinids

After 9 years. I finished it.

(Requires Phil's approval, will put it to ready for review as soon as he gets to see fully the fully finished PR)

* An small update.

Updated meta.json to include all numbers to be equal.
Updated PNG to allow updated numbers to have actual sprites and not just empty sprites.

* Improved the tail sprite.

Proper animation and code.

* Updates ftl for it to properly work.

(cherry picked from commit 5bf246c)
DebugOk referenced this pull request in DebugOk/Delta-v Jan 20, 2024
(cherry picked from commit 3a72289)
@Adrian16199 Adrian16199 deleted the New_felinid_tail branch February 10, 2024 18:57
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

<sub>~~Change from Nyano~~</sub>
Uses space a lot better. The old layout still exists if people want it
for whatever reason.
I also renamed "Default" to "Overlay", which should stay anyway if the
default change is denied.

---

<details><summary><h1>Media</h1></summary>
<p>

## Separated


![image](https://github.com/Simple-Station/Einstein-Engines/assets/77995199/b97c4373-99ac-4ac5-80a5-149122238551)

## Overlay


![image](https://github.com/Simple-Station/Einstein-Engines/assets/77995199/3891756f-91f0-4336-b075-6c461ee1b8e6)

</p>
</details>

---

# Changelog

:cl:
- tweak: UI layout now defaults to separated, the old one is still
available in settings
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants