Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove greentexts - Replace with custom responses #2940

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

beck-thompson
Copy link
Contributor

@beck-thompson beck-thompson commented Feb 9, 2025

About the PR

DeltaV is now officially MRP with no more greentext (source: me). Direction wanted this, and I think its a fun idea. All objectives are still visible to the person completing them, just at the end of round screen you can't tell if an objective is completed or not. Traitors will get a window when evac leaves that they can fill out to explain if they completed the objectives and they can also type in whatever they want mid way through the round by pressing c and clicking the big button. The reason I'm changing the percentages is because I'm hoping this will make traitors have a higher RP level!

Technical details

Nothing too complex. There are some kind of weird things here are the highlights:
image
Probably some more as well but that is the worst

Media

2025-02-08.21-15-08.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • remove: Greentexts are now not visible at the end of round screen. (Test merge)
  • add: You can now write custom objective summaries as traitors. (Test merge)
  • tweak: Round weights have been changed around slightly. (Test merge)

@beck-thompson beck-thompson requested review from a team as code owners February 9, 2025 05:24
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Feb 9, 2025
@Lyndomen
Copy link
Contributor

Direction review in progress, u da mvp

Lyndomen
Lyndomen previously approved these changes Feb 12, 2025
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to see this play out, this is approved for a test merge. Could you update the CL with "Test merge", and could you also include a feedback submission form for the antags :)))

Content.Server/Objectives/ObjectivesSystem.cs Outdated Show resolved Hide resolved
Content.Server/Shuttles/Systems/EmergencyShuttleSystem.cs Outdated Show resolved Hide resolved
Content.Shared.Database/LogType.cs Outdated Show resolved Hide resolved
@beck-thompson
Copy link
Contributor Author

Rider trolled me with those imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants