-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove greentexts - Replace with custom responses #2940
Open
beck-thompson
wants to merge
5
commits into
DeltaV-Station:master
Choose a base branch
from
beck-thompson:1984-greentext
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+311
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltanedas
requested changes
Feb 9, 2025
Content.Server/_DV/CustomObjectiveSummery/CustomObjectiveSummerySystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/_DV/CustomObjectiveSummery/CustomObjectiveSummerySystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/_DV/CustomObjectiveSummery/CustomObjectiveSummerySystem.cs
Outdated
Show resolved
Hide resolved
Content.Client/_DV/CustomObjectiveSummery/CustomObjectiveSummeryWindow.xaml.cs
Outdated
Show resolved
Hide resolved
Content.Client/UserInterface/Systems/Character/CharacterUIController.cs
Outdated
Show resolved
Hide resolved
Direction review in progress, u da mvp |
Lyndomen
previously approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super excited to see this play out, this is approved for a test merge. Could you update the CL with "Test merge", and could you also include a feedback submission form for the antags :)))
deltanedas
requested changes
Feb 12, 2025
Rider trolled me with those imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: UI
Changes: YML
Changes any yml files
S: Needs Review
size/L
256-1023 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
DeltaV is now officially MRP with no more greentext (source: me). Direction wanted this, and I think its a fun idea. All objectives are still visible to the person completing them, just at the end of round screen you can't tell if an objective is completed or not. Traitors will get a window when evac leaves that they can fill out to explain if they completed the objectives and they can also type in whatever they want mid way through the round by pressing c and clicking the big button. The reason I'm changing the percentages is because I'm hoping this will make traitors have a higher RP level!
Technical details
Nothing too complex. There are some kind of weird things here are the highlights:
![image](https://private-user-images.githubusercontent.com/107373427/411288564-6dec9206-8db0-45e6-9081-351695f11ad8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODc5MjEsIm5iZiI6MTczOTQ4NzYyMSwicGF0aCI6Ii8xMDczNzM0MjcvNDExMjg4NTY0LTZkZWM5MjA2LThkYjAtNDVlNi05MDgxLTM1MTY5NWYxMWFkOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QyMzAwMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04MzNiNTk3MDM2ZTQ4MmRmMjc4ZjVkMTFlMTZmYzkxZWRkNzRiZmZiYTAxMjYwNjliMzlkMjQ4NDAzZGUzYjBhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-IO4xZCVbGAZ-P78ZLdaJYQRiAkmWDyum25X3X8uQ88)
Probably some more as well but that is the worst
Media
2025-02-08.21-15-08.mp4
Requirements
Breaking changes
Changelog
🆑