Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Announcer System [PORT] #2652

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Monotheonist
Copy link
Contributor

@Monotheonist Monotheonist commented Jan 8, 2025

About the PR

Lord Deltanedas is gonna scream at me for this one because FUCK!! IT IS A MESS!!

This PR is for the Random Announcer System that EE has, from Parkstation. It is picked from Impstation who has fixed it up, so therefore a good amount of things are labeled as being that.
The long and short of this is that it means we can have more than one station announcer (we used to have Neil, we can bring him back,) and make yet more announcers if we want. It's cool and something I've been pushing for for a while,

Why / Balance

Reason for it being a draft PR is that it almost works, I might need to move the CVars though and that's more than hellish as someone who has little knowledge of C#. If you have any knowledge and you're not a maint, please review this, it's good practice. I am a mighty YAML warrior and I must learn the scriptures.

Technical details

Touches a load of C#, audio, events yaml, if there's an announcement, you name it, it touches it.

Media

TODO

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Guaranteed to fuck with the upstream merge in its current state, possibly.

Changelog

🆑 Monotheonist, Einstein Engines, Impstation

  • add: Added multiple announcers. Now, you don't have to hear just one guy over the PA.

@github-actions github-actions bot added size/XL Over 1024 lines Changes: YML Changes any yml files Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Audio Changes any audio files labels Jan 8, 2025
@hivehum
Copy link

hivehum commented Jan 8, 2025

hello! thanks for porting a feature from imp! it's an honor!

couple notes on our announcers

@github-actions github-actions bot added size/L 256-1023 lines and removed size/XL Over 1024 lines labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes: YML Changes any yml files size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants