Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surgeon access & role #2645

Conversation

sowelipililimute
Copy link
Contributor

@sowelipililimute sowelipililimute commented Jan 7, 2025

About the PR

This adds a surgeon role and separate surgery access.

Why / Balance

Given the potential damage that can be inflicted by surgery, it makes sense both in-character that NanoTrasen would hire different specialities for e.g. someone who is trained in surgery vs someone that's good at being a paramedic, as well as out-of-character, where surgery could potentially be used to break several server rules therefore it makes sense for admins to have a way to roleban someone from the role with access to it.

This also allows for surgeons to have a specific job title, icon, PDA, and loadout that allows them to be immediately distinct from the rest of the medical crew. From "surgeons injure people if they aren't wearing gloves and mask" it follows that having a surgeon's loadout mandate these makes sense.

Technical details

  • Commit 1:
    • sprites for surgeon PDA and ID
    • add prototypes & locale data for ID card and PDA
  • Commit 2:
    • adds a surgeon access level
    • sets up medical staff to have it as appropriate
    • adds it to the consoles
  • Commit 3:
    • adds a surgeon job & loadouts
  • Commit 4:
    • adds surgery door prototypes for map maintainers to use
  • Commit 5:
    • adds surgery locker prototypes for map maintainers to use

Media

grafik
grafik
grafik

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑

  • add: Added a Surgeon job & Surgery access

@sowelipililimute sowelipililimute requested review from a team as code owners January 7, 2025 22:33
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: Map Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

RSI Diff Bot; head commit dee838d merging into aa26ccd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Interface/Misc/job_icons.rsi

State Old New Status
Surgeon Added

Resources/Textures/_DV/Markers/jobs.rsi

State Old New Status
surgeon Added

Resources/Textures/_DV/Objects/Devices/pda.rsi

State Old New Status
pda-surgeon Added

Resources/Textures/_DV/Objects/Misc/id_cards.rsi

State Old New Status
idsurgeon Added

Resources/Textures/_DV/Structures/Storage/closet.rsi

State Old New Status
surgeon Added
surgeon_door Added
surgeon_open Added

Edit: diff updated after dee838d

@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 7, 2025

Meow 24 hours for direction review

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch 2 times, most recently from 7d091f2 to db307c0 Compare January 7, 2025 23:06
@FieldCommand
Copy link
Contributor

Should get a surgeon locker that can contain all the tools they need as well as some general surgeon work apparel.

@boogiebogus
Copy link
Contributor

boogiebogus commented Jan 8, 2025

Honestly, I think making surgery the responsibility of a separate role is a bad idea. As far as medical roles go, medical doctor has always had the short end of the stick--every single other medical role can do everything a medical doctor does, so their only real defining feature is that you're supposed to stay in medbay all shift. As is, a medbay can run just fine without any medical doctors, which feels strange.

Making surgery a separate access is something I'm 100% in support of though--it'd be great to have surgery off limits to roles that aren't medical doctors, so that the entire rest of med isn't literally doctor+ in terms of what they're capable of doing, and give something unique to the medical doctor role.

(Also, if we ever get ss13-style wound med, then med emphasizes surgery far more and we'd probably have to combine medical doctor and surgeon back together because otherwise there's not much someone without surgery access can do)

@Radezolid
Copy link
Contributor

Being mechanically able to do a job is different from being supposed to do it.
A paramedic shouldn't be treating patients unles every medical doctor is busy, same with the chemist.
This PR just gives the surgeon mechanical advantage over the medical doctor, making it the best choice for in case surgery is needed but not the only one.

@FieldCommand FieldCommand mentioned this pull request Jan 8, 2025
2 tasks
Resources/Prototypes/Access/medical.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_DV/Roles/Jobs/Medical/surgeon.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 8, 2025
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch from ff681e9 to d9fe28f Compare January 8, 2025 20:08
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 8, 2025
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch from d9fe28f to b6f4319 Compare January 8, 2025 20:09
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 8, 2025
@sowelipililimute
Copy link
Contributor Author

surgeon locker prototype is added, feel free to nit the contents

@Radezolid
Copy link
Contributor

Nit picks incoming

Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch from 63150f2 to 26835f7 Compare January 9, 2025 03:06
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch from 26835f7 to 507892e Compare January 9, 2025 03:16
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch 2 times, most recently from 109e579 to 6ee8dca Compare January 9, 2025 04:14
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/surgeon-role branch from 6ee8dca to dee838d Compare January 9, 2025 04:16
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Looking forward to seeing this in game, thank you for the work out in.

@deltanedas deltanedas merged commit 9a0abc3 into DeltaV-Station:master Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Map Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants