Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediborg candy refactor #2639

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

deltanedas
Copy link
Member

About the PR

refactored mediborg candy and added 2u to lollipop's solution max volume for spiking

also added admin logging to it since it spawns entities, now admins can see if someone is just spamming candy 24/7 to try lag the server :trollface:

Why / Balance

prediction good
the extra volume lets you spike lollipops, 2u is basically nothing still but more than 1u as it has omni instead of trico

Technical details

  • no longer hardcoded to 2 items. the item spawned is supplied in the action's event, and the component has a list of actions
  • moved to shared and predicted
  • _DV instead of nyano

Media

still real
02:44:26

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

  • everything is now in Content.Shared/_DV/Silicons/Borgs instead of Content.Server/Nyanotrasen/Abilities/Borgs
  • FabricateCandyComponent now has required field actions, which is set for mediborg chassis type
  • Fabricate{Lollipop,Gumball}ActionEvent replaced by FabricateCandyActionEvent

Changelog
no cl no fun

@deltanedas deltanedas requested a review from a team January 7, 2025 14:46
@deltanedas deltanedas requested review from a team as code owners January 7, 2025 14:46
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

RSI Diff Bot; head commit 8073f30 merging into 6d2f6ce
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after 8073f30

Lyndomen
Lyndomen previously approved these changes Jan 7, 2025
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 9, 2025
@deltanedas deltanedas merged commit 60c5291 into DeltaV-Station:master Jan 9, 2025
14 checks passed
@deltanedas deltanedas deleted the nyano-refactor-ops branch January 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants