Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the great namespace refactor #2574

Merged
merged 8 commits into from
Jan 1, 2025

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Jan 1, 2025

About the PR

for C#, prototypes, textures, audio, locale changed the folder from DeltaV/deltav to _DV
maps had Shuttles/DeltaV Nonstations/DeltaV etc moved into _DV/Shuttles and _DV/Nonstations respectively. stations themselves are unchanged

Why / Balance

other forks use this scheme for good reason (appearing at the top of files :trollface:) and this has been long overdue

maps were like that for no reason anyway

Technical details

yep

Media

06:14:13
no errors...

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

for code sed -i Content.*/**.cs Content.Client/**.xaml -e 's!\.DeltaV\.!._DV.!g' -e 's!/DeltaV/!/_DV/!g' and look for any Maps/.../_DV if you referenced them, they need inverting to Maps/_DV/...
for yml sed -i Resources/**.yml -e 's!DeltaV/!_DV/g' and look for maps. bear in mind any instances of DeltaV/Nyano
for any other files just sed them the same way

locale files dont reference the file structure so need no changes

Changelog
hopefully not visible in game :trollface:

@deltanedas deltanedas requested review from a team as code owners January 1, 2025 05:55
@github-actions github-actions bot added size/M 64-255 lines S: Needs Review Changes: YML Changes any yml files Changes: Map Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi Changes: Audio Changes any audio files labels Jan 1, 2025
@deltanedas deltanedas requested a review from a team as a code owner January 1, 2025 06:11
@deltanedas deltanedas merged commit ec94579 into DeltaV-Station:master Jan 1, 2025
12 checks passed
@deltanedas deltanedas deleted the namespace-ops branch January 1, 2025 08:42
@dvir001
Copy link
Contributor

dvir001 commented Jan 1, 2025

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

Cool.

Get-ChildItem -Path "Content.*\*.cs", "Content.Client\*.xaml" -Recurse | ForEach-Object { (Get-Content $_.FullName) -replace '\.DeltaV\.', '._DV.' -replace '/DeltaV/', '/_DV/' | Set-Content $_.FullName }

Get-ChildItem -Path "Resources\*.yml" -Recurse | ForEach-Object { (Get-Content $_.FullName) -replace 'DeltaV/', '_DV/' | Set-Content $_.FullName }

@deltanedas
Copy link
Member Author

most readable powershell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Map Changes: Sprite Changes any png or json in an rsi Changes: UI Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants