Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Machine Incompatible Trait #2395

Merged
merged 14 commits into from
Jan 10, 2025
Merged

Conversation

Emily9031
Copy link
Contributor

About the PR

This adds a new trait that makes characters unable to have their brain put into a man-machine interface.

Why / Balance

I think people wanted it.

Technical details

Added new Unborgable trait, blacklisted any brains with it from being put into MMIs, and caused a message to appear when inspecting brains with this trait.

Media

image
Indicator of a brain that is machine incompatible

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

I don't think I broke anything.
Changelog

🆑

  • add: New Machine Incompatible trait, makes characters unable to have their brain put into a man-machine interface.

@Emily9031 Emily9031 requested review from a team as code owners December 8, 2024 08:39
@github-actions github-actions bot added size/S 16-63 lines Changes: YML Changes any yml files S: Needs Review Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Dec 8, 2024
@Emily9031
Copy link
Contributor Author

I wanted to add a popup when you attempt to put a brain with this trait into an MMI, but I wasn't able to get the code working. If someone knows more and is able to do it, go for it.

Content.Server/Body/Systems/BrainSystem.cs Outdated Show resolved Hide resolved
Content.Server/Body/Systems/BrainSystem.cs Outdated Show resolved Hide resolved
Content.Server/Traits/Assorted/UnborgableComponent.cs Outdated Show resolved Hide resolved
@PubliclyExecutedPig
Copy link

Is like the brother from better call saul

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Changes: UI size/M 64-255 lines and removed size/S 16-63 lines S: Merge Conflict Fix your PR! labels Jan 1, 2025
@deltanedas deltanedas requested a review from Lyndomen January 1, 2025 14:46
deltanedas
deltanedas previously approved these changes Jan 1, 2025
@deltanedas
Copy link
Member

deltanedas commented Jan 1, 2025

02:45:55

you can now only see the examine for the brain itself, to see it for a person you need a health analyzer (will also properly work with surgery and stuff now)

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction good with this still displaying on inspect of brain.

@deltanedas deltanedas merged commit d361ece into DeltaV-Station:master Jan 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants